feat: add storage adapter for hulylake #10032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Connected to Huly®: UBERF-13875 |
There was a problem hiding this comment.
Pull Request Overview
This PR adds storage adapter support for Hulylake, a storage backend service. The main purpose is to integrate Hulylake as a new storage option alongside existing adapters like MinIO, S3, and Datalake.
Key changes include:
- Created a new
@hcengineering/hulylakepackage with storage adapter implementation - Updated Hulylake client interfaces to distinguish between workspace-specific and general clients
- Added Hulylake as a storage option in server configuration
Reviewed Changes
Copilot reviewed 30 out of 31 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| server/hulylake/src/index.ts | Main HulylakeService implementation with StorageAdapter interface |
| packages/hulylake-client/src/client.ts | Refactored client to separate workspace and general client interfaces |
| server/server-storage/src/starter.ts | Added Hulylake storage configuration support |
| services/translate/src/storage.ts | Updated to use new HulylakeWorkspaceClient interface |
| server/indexer/src/indexer/indexer.ts | Updated type references for workspace client |
Files not reviewed (1)
- common/config/rush/pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
aonnikov
force-pushed
the
feat-huylake-storage-adapter
branch
from
bb3b6e0 to
9db75c5
Compare
aonnikov
force-pushed
the
feat-huylake-storage-adapter
branch
from
9db75c5 to
3919490
Compare
kristina-fefelova
previously approved these changes
Oct 10, 2025
Signed-off-by: Alexander Onnikov <[email protected]>
Signed-off-by: Alexander Onnikov <[email protected]>
aonnikov
force-pushed
the
feat-huylake-storage-adapter
branch
from
a30cc2c to
6d1967c
Compare
haiodo
approved these changes
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.